-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
grpc-java channel similars in grpc-go #187
Comments
I still do not understand why you require an interceptor ... It was deliberate to abandon interceptor in our design. |
NP. Let me try to explain better. In TCP socket, we send bytes:
Now that we have protobuf and grpc, we want to send messages instead.
The send(msg) API is provided by the framework, and message should be defined by user. I wonder how can we do it efficiently without letting user define msg/rpc on their own? |
pls tell me how interceptors can help you address this issue? We typically provide send(b []byte) to users instead of send(proto.Message) If you are thinking about the encoding efficiency (e.g., memory alloc and On Mon, May 11, 2015 at 1:55 PM, Hongchao Deng notifications@github.com
|
I guess calling Invoke(...) directly can fit your needs? |
Hi, @iamqizhao
Sorry to raise the old issue again. I think I understand the problem better. We actually want something like what grpc-java channel provides:
https://github.com/grpc/grpc-java#channel
This is very useful for framework developers.
Basically, the framework should be agnostic to message definition by user. It needs to handles the low level details, e.g. creating connection, finding address, flow control.
Ultimately, some generic client method calls is wanted
And interceptor method on server side
Can you think about it and let me know your thoughts?
The text was updated successfully, but these errors were encountered: