-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kill stream client caused server quit silently #193
Comments
This should not happen. I quickly had a glance at the code: The loop at https://github.com/grpc/grpc-go/blob/master/server.go#L193 will It would be good to show me a reproducible example to debug this. On Sun, May 10, 2015 at 10:17 PM, zoutaiqi notifications@github.com wrote:
|
Sorry, it should be caused by my shell script, it works well if the server started by manual, thank you for your quick reply. and I have another question: |
On Mon, May 11, 2015 at 10:56 PM, zoutaiqi notifications@github.com wrote:
|
Got it, thank you very much. and expect the health checking mechanism add in, before that I will set timeout or deadline in context on client side to handle this case. |
HI, @iamqizhao , I got the same problem after I fixed the script issue, and I got a very little output when they quit, I don't know if there is any useful information for you debug. env: goroutine 784 [IO wait]: goroutine 783045 [select, 9 minutes]: |
These logs are not useful. Can you add some logging to the exit points of On Fri, May 15, 2015 at 1:15 AM, zoutaiqi notifications@github.com wrote:
|
thanks,I will try it 发自我的 iPhone
|
Hi, @iamqizhao, this is the last output that some of nodes panic almost at the same time, hope this is helpful for debug, thanks. 2015/05/22 06:56:30 transport: http2Client.notifyError got notified that the client transport was broken EOF. |
Sorry, @iamqizhao , I found a bug might close a channel twice in my program, should be the root cause,I will close this issue. Thanks for your help. |
@iamqizhao @zoutaiqi I'm getting the same |
I need more info to move forward. Can u elaborate what you were doing, what On Mon, Sep 14, 2015 at 12:06 PM, Derek Perkins notifications@github.com
|
@iamqizhao,
Client send request message to server per second, and server return the responses back, two side are stream mode. to reproduce this issue, I comment out the recv response message from server on client side, keep it several seconds, then killed client, server quit silently almost at the same time, no core dump file found on server side. I did this just want to know how server handle this scenario that client crashed(no deadline or timeout set in context on client side, and CloseSend() will not be called due to client crashed)? will the goroutine quit or just block on server side? thanks.
The text was updated successfully, but these errors were encountered: