Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

server checks :authority header in the secure channel #34

Closed
iamqizhao opened this issue Feb 11, 2015 · 1 comment
Closed

server checks :authority header in the secure channel #34

iamqizhao opened this issue Feb 11, 2015 · 1 comment

Comments

@iamqizhao
Copy link
Contributor

We allow users to override the authority per-call, but we currently don't do any verification that that authority would be permitted for the current server. We should verify the provided authority against the TLS cert of the connection and fail in some way if the cert is not good for the requested authority. We would cache these verifications for the connection in a simple hash map.

It is the Java equivalent of grpc/grpc#471

@menghanl
Copy link
Contributor

menghanl commented Jun 12, 2017

This should have been fixed by #1064

@lock lock bot locked as resolved and limited conversation to collaborators Sep 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants