Adding call host (:authority header) check in the secure channel. #471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixes #405. - This change is not tested as it should (only end to end and no negative testing). Will do better when we have testing framework for filters.
|
@ejona86 and @iamqizhao should have a similar check for Java and Go. |
|
Architecturally this looks right to me... assigning over to nnoble to take a bit more thorough look at the details. |
|
There's a few things that I find a tiny bit suspect on that code change. Unfortunately, I can't clone it due to @jboeuf's repository being private. |
nicolasnoble
added a commit
that referenced
this pull request
Feb 11, 2015
Adding call host (:authority header) check in the secure channel.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
negative testing). Will do better when we have testing framework
for filters.