New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for proto3 field presence #3629
Comments
FYI, grpc/grpc PR: grpc/grpc#22998 |
Is this for the proto messages or grpc stubs? |
This is for grpc stubs. The proto3 'optional' feature won't directly affect us because we are not generating classes for messages. But, we still need to add that |
You should file this in the gogo proto repo (github.com/gogo/protobuf) instead. |
Oh wow sorry, I've literally pasted this into the wrong brower tab. |
Proto3 introduced the
optional
syntax to support field presence tracking in release 3.12.0. We need to add support in our grpc protoc plugin.See this doc for more details. Basically we need to add a function
GetSupportedFeatures()
to our grpc protoc plugin to mark our compliance.Please plan to do this in the next release. If not, please let me know. Thanks!
The text was updated successfully, but these errors were encountered: