Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.33.0 should be retracted (using the retract directive) #4383

Closed
menghanl opened this issue May 3, 2021 · 1 comment
Closed

v1.33.0 should be retracted (using the retract directive) #4383

menghanl opened this issue May 3, 2021 · 1 comment

Comments

@menghanl
Copy link
Contributor

menghanl commented May 3, 2021

(This issue is file to track the problem described in #4366.)

Release 1.33.0 was published, and was removed shortly after because it has problems (#3945 (comment)). But the version also shows up in https://pkg.go.dev/google.golang.org/grpc@v1.33.0 even after it's deleted, and the users can still depend on it (by specifying it in go.mod) by mistake.

In go 1.16, a new directive was introduced to help solve this problem: https://golang.org/ref/mod#go-mod-file-retract

But it cannot be used at the time this issue is created, because go versions older than 1.16 are still supported.

@menghanl menghanl changed the title Add retract directive for v1.33.0 v1.33.0 should be retracted (using the retract directive) May 3, 2021
@dfawley
Copy link
Member

dfawley commented May 4, 2021

I don't see the need for this for this particular instance. By the time we can add it (~1yr), v1.33.0 will be so old nobody would have any reason to reference it. It's already 4 releases old, which is typically older than we're willing to maintain via patch releases.

If this kind of thing were to happen again, it's nice to know there is a friendly way of dealing with it.

@dfawley dfawley closed this as completed May 4, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 31, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants