Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.33.0 was released, but removed? #3945

Closed
ukai opened this issue Oct 9, 2020 · 4 comments
Closed

1.33.0 was released, but removed? #3945

ukai opened this issue Oct 9, 2020 · 4 comments

Comments

@ukai
Copy link

ukai commented Oct 9, 2020

It seems 1.33.0 was released
https://pkg.go.dev/google.golang.org/grpc?tab=versions

but removed now?
https://github.com/grpc/grpc-go/releases/tag/v1.33.0 is 404 Not found.

@vvakame
Copy link

vvakame commented Oct 9, 2020

renovate bot automatically pushed the v1.33.0 to (our repository's) master last night and all CI jobs have been failed since then 😿

@menghanl
Copy link
Contributor

menghanl commented Oct 9, 2020

The 1.33.0 release was pushed by mistake. We deleted that, and will skip it and release 1.33.1 later (schedule in two weeks).

1.33.0 still shows in pkg.go.dev because the bad release is cached by https://proxy.golang.org/ (as mentioned in its FAQ).

At this time, please avoid using 1.33.0, and use 1.32.0 instead.
Sorry for the confusion and inconvenience. And let us know if there are other problems.

@blixt
Copy link

blixt commented Oct 15, 2020

This also broke builds for us and our developers – maybe in the future it's better to immediately republish a higher version with the reverted state rather than remove the version? With Go proxies and local caches, it's pretty hard to get rid of a version that is considered the latest version but was removed, leaving you in a flaky state.

@dfawley
Copy link
Member

dfawley commented Oct 15, 2020

maybe in the future it's better to immediately republish a higher version with the reverted state rather than remove the version?

We can't release 1.33.1 as an older stable version of grpc (e.g. 1.32.latest), as that could break backward compatibility requirements (i.e. 1.33.1 wouldn't have some features that 1.33.0 has).

There really aren't many options here. We either have to live with an unstable 1.33.0 release for two weeks or delete it. Neither option is ideal, but leaving an unstable release around seems worse. If tooling can't handle deleted versions, perhaps it can be improved.

The only thing left to do is make sure this doesn't happen again. We'll be updating our internal documentation to be clearer about what needs to be done to create a release branch.

@easwars easwars closed this as completed Oct 15, 2020
jrick added a commit to jrick/dcrwallet that referenced this issue Oct 20, 2020
The v1.33.0 tag was pushed by accident, and the gRPC project
recommends to stick with v1.32.0 until v1.33.1 is available.

See grpc/grpc-go#3945 for more details.
mergify bot added a commit to cosmos/cosmos-sdk that referenced this issue Nov 15, 2020
* Updated gRCP version to v1.33.1 since v1.33.0 was deleted (see grpc/grpc-go#3945)

* Updated CHANGELOG

* Updated CHANGELOG

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
daeMOn63 pushed a commit to fetchai/cosmos-sdk that referenced this issue May 5, 2021
* Updated gRCP version to v1.33.1 since v1.33.0 was deleted (see grpc/grpc-go#3945)

* Updated CHANGELOG

* Updated CHANGELOG

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

6 participants