-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
xds/federation: support populating resource template in xds-resolver #4900
Conversation
This PR is based on #4892. All new changes are in the last commit. |
448cb60
to
cfba88f
Compare
85457ab
to
da6d4c7
Compare
This is rebased on master. But the commit history is lost. |
53a360b
to
40ab629
Compare
tgt := target | ||
if opts.target != nil { | ||
tgt = *opts.target | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a bit of magic where we get the target
from a global var if not set in opts
. This makes the tests harder to read since the reader will have to keep track of all this. Instead, could we just always pass a valid target
from tests?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
6c8bf77
to
27f50c7
Compare
[federation_target_parsing] template populate [federation_target_parsing] default bootstrap for test client [federation_target_parsing] fixed resolver tests, new tests not added yet [federation_target_parsing] new tests [federation_target_parsing] fix test [federation_target_parsing] c1
27f50c7
to
ec1a81f
Compare
And also handle percent encoding for new style resource names.
RELEASE NOTES: