Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky test: 12/10k: UnmarshalListener_WithUpdateValidatorFunc #5231

Closed
easwars opened this issue Mar 9, 2022 · 22 comments
Closed

Flaky test: 12/10k: UnmarshalListener_WithUpdateValidatorFunc #5231

easwars opened this issue Mar 9, 2022 · 22 comments
Assignees
@zasweq
Labels
fixit P1 Type: Testing

Comments

@easwars
Copy link
Contributor

easwars commented Mar 9, 2022

https://github.com/grpc/grpc-go/runs/5472908166?check_suite_focus=true
@easwars
Copy link
Contributor Author

easwars commented Mar 21, 2022

https://github.com/grpc/grpc-go/runs/5634991537?check_suite_focus=true

@dfawley
Copy link
Member

dfawley commented Apr 5, 2022 •
edited
Loading

https://github.com/grpc/grpc-go/runs/5841087680?check_suite_focus=true

(x2 in this PR)

@dfawley
Copy link
Member

dfawley commented Nov 28, 2022

Failing 12/10k on google3.

@dfawley dfawley changed the title Flaky test: UnmarshalListener_WithUpdateValidatorFunc Flaky test: 12/10k: UnmarshalListener_WithUpdateValidatorFunc Nov 28, 2022
This was referenced Dec 5, 2022
Merged
Closed
Closed
@easwars easwars mentioned this issue Jan 12, 2023
Merged
@arvindbr8
Copy link
Member

https://github.com/grpc/grpc-go/actions/runs/5062033494/jobs/9087044357?pr=6298

@zasweq
Copy link
Contributor

zasweq commented May 24, 2023

https://github.com/zasweq/grpc-go/actions/runs/5068326892/jobs/9100504652

@dfawley
Copy link
Member

dfawley commented May 24, 2023

https://github.com/grpc/grpc-go/actions/runs/5073008191/jobs/9111471736?pr=6314#step:8:198

@zasweq
Copy link
Contributor

zasweq commented May 25, 2023

https://github.com/grpc/grpc-go/actions/runs/5073937512/jobs/9113575290?pr=6296

@dfawley dfawley added P1 and removed P2 labels May 31, 2023
@dfawley
Copy link
Member

dfawley commented May 31, 2023

https://github.com/grpc/grpc-go/actions/runs/5134976897/jobs/9239750602?pr=6331#step:8:198

@dfawley
Copy link
Member

dfawley commented Jun 6, 2023

https://github.com/grpc/grpc-go/actions/runs/5193271248/jobs/9363590170?pr=6351#step:8:200

@zasweq
Copy link
Contributor

zasweq commented Jun 8, 2023

https://github.com/grpc/grpc-go/actions/runs/5207214049/jobs/9394543268?pr=6361

@zasweq
Copy link
Contributor

zasweq commented Jun 8, 2023

https://github.com/grpc/grpc-go/actions/runs/5213995695/jobs/9409707907?pr=6362

@zasweq
Copy link
Contributor

zasweq commented Jun 9, 2023

https://github.com/zasweq/grpc-go/actions/runs/5225767251/jobs/9435653328

@zasweq
Copy link
Contributor

zasweq commented Jun 10, 2023

https://github.com/grpc/grpc-go/actions/runs/5226986500/jobs/9438156058

@zasweq
Copy link
Contributor

zasweq commented Jun 15, 2023

https://github.com/grpc/grpc-go/actions/runs/5273478328/jobs/9536957357?pr=6372

@arvindbr8
Copy link
Member

https://github.com/grpc/grpc-go/actions/runs/5279933026/jobs/9551325584?pr=6374

@zasweq
Copy link
Contributor

zasweq commented Jun 17, 2023

https://github.com/zasweq/grpc-go/actions/runs/5294903669/jobs/9584721694

@zasweq
Copy link
Contributor

zasweq commented Jun 17, 2023

https://github.com/zasweq/grpc-go/actions/runs/5294867299/jobs/9584651939

@zasweq
Copy link
Contributor

zasweq commented Jun 27, 2023

https://github.com/grpc/grpc-go/actions/runs/5393587878/jobs/9794046289?pr=6359, luckily fix is in flight.

@easwars easwars assigned zasweq and unassigned easwars Jun 30, 2023
@easwars
Copy link
Contributor Author

easwars commented Jun 30, 2023

@zasweq : Would you mind running this on google3 once the import is done to see how well this fix addresses the issue, and if we come down to something that <10 flakes for 10k runs, we can maybe close this or at least make it p2. Thanks.

@zasweq
Copy link
Contributor

zasweq commented Jul 6, 2023 •
edited
Loading

Fails a ton still, but I realized the fix is part of my import this week. Retrying now on import citc client.

@zasweq
Copy link
Contributor

zasweq commented Jul 6, 2023

This passes /10k runs in Forge with my change. Thus, closing this issue :).

@zasweq zasweq closed this as completed Jul 6, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 3, 2024
@arvindbr8
Copy link
Member

https://github.com/grpc/grpc-go/actions/runs/9965087957/job/27534681892?pr=7409

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@zasweq zasweq

Labels
fixit P1 Type: Testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@menghanl @easwars @arvindbr8 @dfawley @zasweq