Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: server should fail Serve() if called after Close() #5838

Closed
easwars opened this issue Dec 2, 2022 · 1 comment · Fixed by #6410
Closed

xds: server should fail Serve() if called after Close() #5838

easwars opened this issue Dec 2, 2022 · 1 comment · Fixed by #6410
Assignees
@easwars
Labels
P2 Type: Bug

Comments

@easwars
Copy link
Contributor

easwars commented Dec 2, 2022

Currently this can lead to a leaked xDS client, as the latter is created in Serve() and closed in `Close().
@easwars easwars self-assigned this Dec 2, 2022
@easwars
Copy link
Contributor Author

easwars commented Dec 5, 2022

This is a cause for some of the flakiness in #5231.

@zasweq zasweq mentioned this issue Jun 23, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@easwars easwars

Labels
P2 Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

xds: Fail xDS Server Serve() if called after Stop() or GracefulStop() zasweq/grpc-go
1 participant
@easwars