Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weightedtarget: return a more meaningful error when no child policy is reporting READY #5391

Closed
easwars opened this issue Jun 2, 2022 · 1 comment · Fixed by #5711
Closed

Comments

@easwars
Copy link
Contributor

easwars commented Jun 2, 2022

Currently, if none of the children of the weightedtarget LB policy are reporting READY, the parent policy simply returns a picker which returns an error all the time with a message of "all subConns are in TransientFailure".

picker = base.NewErrPicker(balancer.ErrTransientFailure)

This does not provide the user with any actionable information to fix the underlying problem. Surfacing the status message from the failing child pickers would give actionable information to the user to fix the underlying problem.

Java returns a weighted picker of all failing pickers in this scenario and C-core is planning to do the same. We should also do something similar.

@zasweq zasweq added the P1 label Jun 14, 2022
@easwars easwars added the fixit label Jun 21, 2022
@easwars easwars removed their assignment Oct 11, 2022
@arvindbr8
Copy link
Member

@zasweq ping to assign this issue to me

arvindbr8 added a commit to arvindbr8/grpc-go that referenced this issue Oct 12, 2022
arvindbr8 added a commit to arvindbr8/grpc-go that referenced this issue Oct 12, 2022
arvindbr8 added a commit to arvindbr8/grpc-go that referenced this issue Oct 12, 2022
arvindbr8 added a commit to arvindbr8/grpc-go that referenced this issue Oct 12, 2022
arvindbr8 added a commit to arvindbr8/grpc-go that referenced this issue Oct 12, 2022
arvindbr8 added a commit to arvindbr8/grpc-go that referenced this issue Oct 12, 2022
arvindbr8 added a commit to arvindbr8/grpc-go that referenced this issue Oct 13, 2022
arvindbr8 added a commit to arvindbr8/grpc-go that referenced this issue Oct 17, 2022
arvindbr8 added a commit that referenced this issue Oct 17, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants