Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support XDS HeaderMatcher string_match api (v3) #5649

Closed
jacob-delgado opened this issue Sep 9, 2022 · 2 comments
Closed

Support XDS HeaderMatcher string_match api (v3) #5649

jacob-delgado opened this issue Sep 9, 2022 · 2 comments
Labels
P2 Status: Blocked Type: Feature New features or improvements in behavior

Comments

@jacob-delgado
Copy link

Use case(s) - what problem will this feature solve?

Allow the use of the match_string in envoyproxy/go-control-plane XDS support for gRPC clients. Currently, only the deprecated API is supported.

Proposed Solution

#5648

Alternatives Considered

None

Additional Context

This is preventing istio/istio#40886 from getting merged for Istio.
@jacob-delgado jacob-delgado added the Type: Feature New features or improvements in behavior label Sep 9, 2022
@jacob-delgado jacob-delgado mentioned this issue Sep 9, 2022
Closed
@zasweq zasweq self-assigned this Sep 9, 2022
@zasweq zasweq removed their assignment Sep 20, 2022
@dfawley dfawley added the P2 label Sep 27, 2022
@dfawley
Copy link
Member

dfawley commented Sep 27, 2022

Thanks for the request. This is the kind of feature that would need to be implemented in all languages after a gRFC is created for it. @gnossen was looking into doing this at some point in the not-too-distant future IIUC.

@easwars
Copy link
Contributor

easwars commented Nov 28, 2022

The request makes sense. But as mentioned in the previous comment, this would need a gRFC and would have to be implemented in all languages. Please feel free to send a proposal to the grpc proposal repo and we can take it from there. Thank you very much.

@easwars easwars closed this as completed Nov 28, 2022
@dfawley dfawley closed this as not planned Won't fix, can't repro, duplicate, stale Nov 28, 2022
@dfawley dfawley mentioned this issue Jan 10, 2023
Closed
@dfawley dfawley mentioned this issue Feb 7, 2023
Closed
@easwars easwars mentioned this issue May 2, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
P2 Status: Blocked Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update header matcher to use v3 string_match api
4 participants
@easwars @dfawley @jacob-delgado @zasweq