Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds HeaderMatcher support StringMatch #5917

Closed
wulianglongrd opened this issue Jan 10, 2023 · 1 comment
Closed

xds HeaderMatcher support StringMatch #5917

wulianglongrd opened this issue Jan 10, 2023 · 1 comment
Labels
Status: Duplicate Type: Feature New features or improvements in behavior

Comments

@wulianglongrd
Copy link

Use case(s) - what problem will this feature solve?

xds HeaderMatcher support string_match, because exact_match, prefix_match, suffix_match, contains_match, safe_regex_match has been deprecated. xds api see here.

Proposed Solution

Add a new HeaderMatcher implements for string_match.

Alternatives Considered

N/A

Additional Context

N/A
@wulianglongrd wulianglongrd added the Type: Feature New features or improvements in behavior label Jan 10, 2023
@wulianglongrd wulianglongrd mentioned this issue Jan 10, 2023
Closed
@dfawley
Copy link
Member

dfawley commented Jan 10, 2023

I believe this is #5649, but this needs a gRFC before implementing so we can be sure all languages are working on it together.

@dfawley dfawley closed this as completed Jan 10, 2023
@wulianglongrd wulianglongrd mentioned this issue Jan 11, 2023
Merged
@easwars easwars mentioned this issue May 2, 2023
Closed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Status: Duplicate Type: Feature New features or improvements in behavior
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wulianglongrd @dfawley