Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cluster resolver error handling #6462

Closed
zasweq opened this issue Jul 20, 2023 · 0 comments · Fixed by #6461
Closed

Fix cluster resolver error handling #6462

zasweq opened this issue Jul 20, 2023 · 0 comments · Fixed by #6461
Assignees
Milestone

Comments

@zasweq
Copy link
Contributor

zasweq commented Jul 20, 2023

We need to fix cluster_resolver error handing. The desired behavior as per gRFC A37 is to create a priority and send down an empty address list if an EDS Discovery Mechanism or DNS Discovery Mechanism errors before a first good update, triggering Transient Failure for that priority and causing fallback if another lower level priority. In master, we simply don't create the priority child in the EDS case and send down a resolver error in the DNS case.

@zasweq zasweq self-assigned this Jul 20, 2023
@zasweq zasweq added the P2 label Jul 20, 2023
@zasweq zasweq added this to the 1.57 Release milestone Jul 20, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant