grpc: add ability to compile with or without tracing #6954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #6954 +/- ##
==========================================
- Coverage 83.72% 83.61% -0.12%
==========================================
Files 287 288 +1
Lines 30915 30921 +6
==========================================
- Hits 25884 25854 -30
- Misses 3969 3999 +30
- Partials 1062 1068 +6
|
|
I added a release notes string, the test failure looks like a flake to me. Seems ready for review :) |
dfawley
reviewed
Feb 2, 2024
golang.org/x/net/trace is the only dependency of gRPC Go that depends -- through html/template and text/template -- on reflect's MethodByName. Binaries with MethodByName are not eligible for Go dead code elimination. As of protobuf v1.32.0 combined with Go 1.22, Go protobufs support compilation with dead code elimination. This commit allows users of gRPC Go to also make use of dead code elimination for smaller binary sizes. Signed-off-by: Chris Koch <chrisko@google.com>
|
Thanks @dfawley! |
smira
added a commit
to smira/talos
that referenced
this pull request
Feb 22, 2024
See grpc/grpc-go#6954 Before: ``` -rw-r--r-- 1 smira smira 68241300 Feb 20 20:08 _out/initramfs-amd64.xz ``` After: ``` -rw-r--r-- 1 smira smira 66376648 Feb 20 20:08 _out/initramfs-amd64.xz ``` Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
dsseng
pushed a commit
to dsseng/talos
that referenced
this pull request
Mar 7, 2024
See grpc/grpc-go#6954 Before: ``` -rw-r--r-- 1 smira smira 68241300 Feb 20 20:08 _out/initramfs-amd64.xz ``` After: ``` -rw-r--r-- 1 smira smira 66376648 Feb 20 20:08 _out/initramfs-amd64.xz ``` Signed-off-by: Andrey Smirnov <andrey.smirnov@siderolabs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
golang.org/x/net/trace is the only dependency of gRPC Go that depends -- through html/template and text/template -- on reflect's MethodByName. Binaries with MethodByName are not eligible for Go dead code elimination.
As of protobuf v1.32.0 combined with Go 1.22, Go protobufs support compilation with dead code elimination. This commit allows users of gRPC Go to also make use of dead code elimination for smaller binary sizes.
What's the best place to insert a build test to make sure that
go build -tags=grpcnotrace ./...still builds?RELEASE NOTES:
x/net/traceby usinggrpcnotraceto enable dead code elimination