Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc: add ability to compile with or without tracing #6954

Merged
merged 1 commit into from
Feb 2, 2024
Merged

grpc: add ability to compile with or without tracing #6954

merged 1 commit into from
Feb 2, 2024

Commits on Feb 2, 2024

  1. grpc: add ability to compile with or without tracing 

    golang.org/x/net/trace is the only dependency of gRPC Go that depends --
through html/template and text/template -- on reflect's MethodByName.
Binaries with MethodByName are not eligible for Go dead code
elimination.

As of protobuf v1.32.0 combined with Go 1.22, Go protobufs support
compilation with dead code elimination. This commit allows users of gRPC
Go to also make use of dead code elimination for smaller binary sizes.

Signed-off-by: Chris Koch <chrisko@google.com>
    @hugelgupf
    hugelgupf committed Feb 2, 2024
    Configuration menu
    Copy the full SHA
    76b9bfe View commit details
    Browse the repository at this point in the history