-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add godoc linter #7444
Comments
Before we enforce revive, we need to fix existing lint issues caught in #7472 as part of vet check. Its fine to change several files in a single PR if they all fix one type of issue or are otherwise related. However, be reasonable and try to keep the PRs small enough to make it not take a long time to review and avoid merge conflicts. |
@purnesh42H Please assign me this issue. |
@purnesh42H Right now, In the tests (vet) I'm getting like don't use an underscore in package name https://revive.run/r#var-naming. |
@purnesh42H Fixed some of the godoc-linter issues. Please review and let me know if any changes are required. Please find the PR below. |
@purnesh42H Fixed linter issues for superfluous-else, increment-decrement, indent-error-flow, var-declaration. Please review the changes. |
@purnesh42H Fixed below godoc linter issues. Please find the PRs below. Please let me know if any changes are required. 15 redefines-builtin-id |
Thanks. LGTM. Please open the. PR in main repo. |
@purnesh42H Fixed below godoc linter issues and raised a PR to main repo. 6 var-declaration |
Since removing golint, we've had numerous occasions of missing docstrings. This seems like the consensus replacement for golint: https://github.com/mgechev/revive -- we should set it up to at least check the docstrings.
The text was updated successfully, but these errors were encountered: