Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drop usage of obsolete oauth2.Context #100

Merged
merged 1 commit into from Mar 5, 2015
Merged

drop usage of obsolete oauth2.Context #100

merged 1 commit into from Mar 5, 2015

Conversation

adg
Copy link
Contributor

@adg adg commented Mar 5, 2015

No description provided.

@dsymonds
Copy link
Contributor

dsymonds commented Mar 5, 2015

LGTM

@iamqizhao
Copy link
Contributor

LGTM, waiting for Travis result before merging ...

On Wed, Mar 4, 2015 at 7:47 PM, David Symonds notifications@github.com
wrote:

LGTM


Reply to this email directly or view it on GitHub
#100 (comment).

@adg
Copy link
Contributor Author

adg commented Mar 5, 2015

Travis reports this failure:

../../../google.golang.org/grpc/credentials/credentials.go:206: undefined: oauth2.Context

But this CL specifically removes oauth2.Context from that line in that file.

Looking at the build log, it looks like the script that fetches and tests the code does not apply the pull request patch between running go get and go test.

@iamqizhao
Copy link
Contributor

On Wed, Mar 4, 2015 at 7:57 PM, Andrew Gerrand notifications@github.com
wrote:

Travis reports this failure:

../../../google.golang.org/grpc/credentials/credentials.go:206: undefined: oauth2.Context

But this CL specifically removes oauth2.Context from that line in that
file.

Looking at the build log, it looks like the script that fetches and tests
the code does not apply the pull request patch between running go get and go
test.

This sounds very serious bug ...

Should I go ahead merging your PR now and leave this issue later?


Reply to this email directly or view it on GitHub
#100 (comment).

iamqizhao added a commit that referenced this pull request Mar 5, 2015
drop usage of obsolete oauth2.Context
@iamqizhao iamqizhao merged commit 8dd67cb into grpc:master Mar 5, 2015
@adg
Copy link
Contributor Author

adg commented Mar 5, 2015

Now I can't find the build failure log from travis?! It just disappeared.

@iamqizhao
Copy link
Contributor

because I restarted it ...

On Wed, Mar 4, 2015 at 8:10 PM, Andrew Gerrand notifications@github.com
wrote:

Now I can't find the build failure log from travis?! It just disappeared.


Reply to this email directly or view it on GitHub
#100 (comment).

@iamqizhao
Copy link
Contributor

now it tries to fetch the pull request which was merged and fails ...

On Wed, Mar 4, 2015 at 8:12 PM, Qi Zhao toqizhao@gmail.com wrote:

because I restarted it ...

On Wed, Mar 4, 2015 at 8:10 PM, Andrew Gerrand notifications@github.com
wrote:

Now I can't find the build failure log from travis?! It just disappeared.


Reply to this email directly or view it on GitHub
#100 (comment).

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants