Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metadata: Remove NewContext and FromContext for gRFC L7 #1392

Merged
merged 1 commit into from
Aug 17, 2017
Merged

metadata: Remove NewContext and FromContext for gRFC L7 #1392

merged 1 commit into from
Aug 17, 2017

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Jul 26, 2017

@dfawley dfawley added the Type: API Change Breaking API changes (experimental APIs only!) label Jul 26, 2017
@dfawley dfawley requested a review from menghanl July 26, 2017 22:53
@dfawley dfawley self-assigned this Jul 28, 2017
@dfawley dfawley changed the title Remove NewContext and FromContext for gRFC L7 metadata: Remove NewContext and FromContext for gRFC L7 Aug 17, 2017
@dfawley dfawley merged commit 596a6ac into grpc:master Aug 17, 2017
@eekwong
Copy link

eekwong commented Aug 17, 2017

Can someone check if this is related to this change?
github.com/grpc-ecosystem/grpc-gateway/examples/server/a_bit_of_everything.go:137: undefined: metadata.FromContext

@dfawley
Copy link
Member Author

dfawley commented Aug 17, 2017

Yes. This PR is a breaking change. grpc-gateway needs to be updated to use metadata.FromIncomingContext or FromOutgoingContext, whichever is appropriate based upon its usage.

Arista-Jenkins pushed a commit to aristanetworks/goarista that referenced this pull request Aug 17, 2017
@aaronbee
gnmi, openconfig/client: Remove use of metadata.NewContext
ae9c939 
NewContext has been deprecated in favor of NewOutgoingContext. See
grpc/grpc-go#1392

Change-Id: Ieb3491f032cdaa1eb59878451c29fefe71efada0
@daviddrysdale daviddrysdale mentioned this pull request Aug 18, 2017
Merged
daviddrysdale added a commit to daviddrysdale/trillian that referenced this pull request Aug 18, 2017
@daviddrysdale
vendor/etcd: don't use now-removed deprecated methods
10977b0 
grpc/grpc-go#1392 has removed metadata.NewContext
and metadata.FromContext, so (locally) change invocations in our vendored etcd
code.
@daviddrysdale daviddrysdale mentioned this pull request Aug 18, 2017
Merged
daviddrysdale added a commit to google/trillian that referenced this pull request Aug 18, 2017
@daviddrysdale
vendor/etcd: don't use now-removed deprecated methods
b144701 
grpc/grpc-go#1392 has removed metadata.NewContext
and metadata.FromContext, so (locally) change invocations in our vendored etcd
code.
This was referenced Aug 18, 2017
Merged
Merged
@brianfoshee brianfoshee mentioned this pull request Aug 19, 2017
Closed
albertito added a commit to albertito/remoteu2f that referenced this pull request Aug 22, 2017
@albertito
proxy: Update to the new GRPC metadata API
a9778ce 
metadata.FromContext has been deprecated, for our use case we need to
call metadata.FromIncomingContext instead.

grpc/grpc-go#1392
grpc/proposal@c8857c2
@joshuarubin joshuarubin mentioned this pull request Aug 24, 2017
Closed
@menghanl menghanl added the 1.6 label Aug 24, 2017
@dfawley dfawley modified the milestone: 1.6 Release Aug 28, 2017
@dfawley dfawley deleted the metadata_l7 branch August 29, 2017 20:15
menghanl pushed a commit to menghanl/grpc-go that referenced this pull request Aug 30, 2017
@dfawley @menghanl
metadata: Remove NewContext and FromContext for gRFC L7 (grpc#1392)
19c4008
daviddrysdale added a commit to daviddrysdale/certificate-transparency-go that referenced this pull request Sep 11, 2017
@daviddrysdale
vendor/etcd: don't use now-removed deprecated methods
c2ccceb 
grpc/grpc-go#1392 has removed metadata.NewContext
and metadata.FromContext, so (locally) change invocations in our vendored etcd
code.
daviddrysdale added a commit to daviddrysdale/certificate-transparency-go that referenced this pull request Sep 11, 2017
@daviddrysdale
vendor/etcd: don't use now-removed deprecated methods
0de4c7b 
grpc/grpc-go#1392 has removed metadata.NewContext
and metadata.FromContext, so (locally) change invocations in our vendored etcd
code.
AlekSi added a commit to AlekSi/grpc-gateway that referenced this pull request Sep 13, 2017
@AlekSi
Fix build.
6e5940f 
See grpc/grpc-go#1392.
achew22 pushed a commit to grpc-ecosystem/grpc-gateway that referenced this pull request Sep 14, 2017
@AlekSi @achew22
Fix build.
185dda2 
See grpc/grpc-go#1392.
@redbaron
Copy link

This breaks API, why there were no major version bump?

@dfawley
Copy link
Member Author

dfawley commented Sep 15, 2017 •
edited
Loading

We don't have a policy of bumping the major version number on API changes. gRPC 2.0 is reserved for when wire protocol changes are made that will require a new version of gRPC across languages. We have changed our API in 1.x and expect to do so in upcoming releases as well.

This change was broadcast months in advance through all means available (grpc-io mailing list, proposals repo, here). And it was listed under "API Changes" in the release notes of 1.6. Sorry for the breakage this caused, but I don't think there's anything else we could have done here.

EDIT: I locked this thread because I don't think it's productive to have any further general discussion about versioning or API breakages here. Please file a new issue against the repo if you want to discuss our policies/etc.

@grpc grpc locked and limited conversation to collaborators Sep 15, 2017
@dfawley
Copy link
Member Author

dfawley commented Oct 17, 2017

As an update to my comment above:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees

@dfawley dfawley

Labels
Type: API Change Breaking API changes (experimental APIs only!)
Projects
None yet
Milestone
1.6 Release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dfawley @eekwong @redbaron @menghanl