Update go_package declarations #1593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
menghanl
reviewed
Oct 19, 2017
| @@ -15,7 +15,7 @@ | |||
| syntax = "proto3"; | |||
|
|
|||
| package grpc.lb.v1; | |||
| option go_package = "messages"; | |||
| option go_package = "google.golang.org/grpc/grpclb/grpc_lb_v1/messages"; | |||
There was a problem hiding this comment.
Changing this option also changes the output file path. (Run make proto to see the result).
It seems our current proto structure (or just the way we run protoc) doesn't work well with this new go_package. We need to fix that.
There was a problem hiding this comment.
The fix for this is to change the --go_out parameter for go generate in grpclb_test.go
diff --git a/grpclb/grpclb_test.go b/grpclb/grpclb_test.go
index 46c1fe5..cc8d75c 100644
--- a/grpclb/grpclb_test.go
+++ b/grpclb/grpclb_test.go
@@ -16,8 +16,8 @@
*
*/
-//go:generate protoc --go_out=plugins=:. grpc_lb_v1/messages/messages.proto
-//go:generate protoc --go_out=Mgrpc_lb_v1/messages/messages.proto=google.golang.org/grpc/grpclb/grpc_lb_v1/messages,plugins=grpc:. grpc_lb_v1/service/service.proto
+//go:generate protoc --go_out=plugins=:$GOPATH grpc_lb_v1/messages/messages.proto
+//go:generate protoc --go_out=plugins=grpc:$GOPATH grpc_lb_v1/service/service.proto
// Package grpclb_test is currently used only for grpclb testing.
package grpclb_test
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The expected contents of
go_packagehas changed, see golang/protobuf#139This is needed to build stuff with bazel - see bazelbuild/rules_go#836