Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add functions to ClientConn so it satisfies an interface for generated code #1599

Merged
merged 2 commits into from
Oct 20, 2017
Merged

Add functions to ClientConn so it satisfies an interface for generated code #1599

merged 2 commits into from
Oct 20, 2017

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Oct 19, 2017

Updates #1287, #589

@dfawley dfawley requested a review from MakMukhi October 20, 2017 20:31
menghanl
menghanl approved these changes Oct 20, 2017
View reviewed changes
Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@dfawley dfawley merged commit a5986a5 into grpc:master Oct 20, 2017
@dfawley dfawley deleted the clientconn_invoker_streamer branch October 20, 2017 21:33
@menghanl menghanl added this to the 1.8 Release milestone Nov 7, 2017
@menghanl menghanl added the Type: API Change Breaking API changes (experimental APIs only!) label Nov 7, 2017
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

@MakMukhi MakMukhi Awaiting requested review from MakMukhi

Assignees

@MakMukhi MakMukhi

Labels
Type: API Change Breaking API changes (experimental APIs only!)
Projects
None yet
Milestone
1.8 Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dfawley @menghanl @MakMukhi