Acquire all stream related quota and cache it locally since no more than one write can happen in parallel on stream #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly one write can happen on a stream at a time.
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
|
I signed it! |
dfawley
reviewed
Oct 25, 2017
transport/http2_client.go
Outdated
| if size > streamQuota { | ||
| size = streamQuota | ||
| } // No need to do that for localSendQuota since that's only a soft limit. | ||
| streamQuota -= size |
There was a problem hiding this comment.
I think the code would be clearer as:
if tq < size {
size = tq
}
streamQuota -= size
localSendQuota -= size
transport/transport_test.go
Outdated
| runPingPongTest(t, 1048576) | ||
| } | ||
|
|
||
| func runPingPongTest(t *testing.T, msgSize int) { |
There was a problem hiding this comment.
Can you add a comment to say what this test is supposed to catch that our other tests don't?
dfawley
reviewed
Oct 25, 2017
transport/transport_test.go
Outdated
| @@ -2183,6 +2183,10 @@ func TestPingPong1MB(t *testing.T) { | |||
| runPingPongTest(t, 1048576) | |||
| } | |||
|
|
|||
| // The continous ping-pong of data on a stream is meant to excercise the | |||
| // flow-control logic to catch potential deadlocks. | |||
| // These tests were added after a deadlock was caught by benchmarking | |||
There was a problem hiding this comment.
You can leave this bit of trivia out...
Maybe say: "This is a stress-test of flow control logic"?
dfawley
approved these changes
Oct 25, 2017
menghanl
added
the
Type: Performance
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small optimization upon which a follow optimization will be built to reduce lock contention.
Benchmarks: https://docs.google.com/a/google.com/spreadsheets/d/1G-p6-uTt8IHRLGXLuTR6TAxeL3I5krVf5r9C86cJPDc/edit?usp=sharing