Fix a bug that could lead to excess, unused connections in long-lived clients #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MakMukhi
approved these changes
Nov 2, 2017
dfawley
approved these changes
Nov 2, 2017
|
@menghanl Are we getting this fix for Thanks! |
|
Will do 1.7.2 this week. |
menghanl
added a commit
that referenced
this pull request
Nov 3, 2017
|
Please pardon my tone in advance: what is the point of a commit message (and release description) that reads "Check ac state shutdown before setting it to TransientFailure"? I can already read the code, thanks. How can anyone reason about this change without intimately knowing the code? This is a pattern I've noticed routinely in this project - release notes are for the public, please be mindful of that when writing them. cc @dfawley |
dfawley
changed the title
|
@tamird, I agree, thanks for the reminder. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.