Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation comments in rpc_util.go #1691

Merged
merged 4 commits into from
Dec 18, 2017

Conversation

dnephin
Copy link
Contributor

@dnephin dnephin commented Nov 27, 2017

The golang convention for deprecating functions is to use Deprecated:. Most deprecated functions in this repo follow the convention, however a few in rpc_util.go use Deprecated; (semicolon).

This PR fixes the comment string so that staticcheck will correctly recognize the function as deprecated.

@thelinuxfoundation
Copy link

Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement.

After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.

Regards,
The Linux Foundation CLA GitHub bot

@dfawley
Copy link
Member

dfawley commented Nov 30, 2017

This can't be done until gRPC itself stops using the deprecated functions. If you would like to make those changes as well, we can approve them; otherwise, we will wait until we have the cycles to do that.

@dnephin dnephin force-pushed the use-standard-deprecation-comment branch from 79bd542 to 6441a04 Compare December 5, 2017 20:31
@dnephin
Copy link
Contributor Author

dnephin commented Dec 5, 2017

I've updated 2 of 3. I'll try and get the last one sometime soon.

@dnephin dnephin force-pushed the use-standard-deprecation-comment branch from 6441a04 to 56cd6fb Compare December 11, 2017 21:20
@dnephin
Copy link
Contributor Author

dnephin commented Dec 11, 2017

The build failure on go1.9 seems unrelated, but I'm not sure. I think this is ready for a review

@dfawley
Copy link
Member

dfawley commented Dec 14, 2017

The build failure on 1.9 is the gofmt check failing -- can you rerun it please? This also needs a rebase to resolve the conflict in balancer_switching_test.go Thanks!

Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin dnephin force-pushed the use-standard-deprecation-comment branch 3 times, most recently from a2d0c56 to 0a67b09 Compare December 18, 2017 16:51
Signed-off-by: Daniel Nephin <dnephin@gmail.com>
@dnephin
Copy link
Contributor Author

dnephin commented Dec 18, 2017

Fixed the conflicts, build is green

Copy link
Member

@dfawley dfawley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks for seeing this through!

@dfawley dfawley merged commit 4e393e0 into grpc:master Dec 18, 2017
@dfawley dfawley added the Type: API Change Breaking API changes (experimental APIs only!) label Dec 18, 2017
@dnephin dnephin deleted the use-standard-deprecation-comment branch December 18, 2017 17:27
@dfawley dfawley added this to the 1.9 Release milestone Jan 2, 2018
@lock lock bot locked as resolved and limited conversation to collaborators Jan 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: API Change Breaking API changes (experimental APIs only!)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants