use the request context with net/http handler #1696
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the grpc server is used as a
net/http
handler the request context is being discarded. This breaks logging and other uses where grpc and http are served on the same port in a Go application.This PR adds the request context to the server transport. I see that grpc is maintaining compatibility down to 1.6 so I'm happy to make the context changes backwards compatible. Looking to get some initial feedback first.