Use options pattern to allow overriding of LookupSRV and LookupHost. #2634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
Signed-off-by: Tom Wilkie <tom.wilkie@gmail.com>
|
Hi @tomwilkie, apology for my late reply. I took a look at the code, and found that you are proposing change to our DNS resolver for the deprecated resolver API v1. We keep this implementation of DNS resolve for backward compatibility. I would suggest having your own separate DNS resolver implementation (essentially DNS resolver v1 with your change here), instead of checking in the change here. FYI, DNS resolver which conforms to resolver API v2 is here: https://github.com/grpc/grpc-go/tree/master/resolver/dns. Let me know if you have further questions. Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Need to override LookupSRV as go1.11 got strict about SRV lookups on old k8s cluster: golang/go#27546.
Signed-off-by: Tom Wilkie tom.wilkie@gmail.com