bufconn: Implement read/write deadlines #2959
Conversation
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
Maydell
force-pushed
the
bufconn-deadlines
branch
from
f411d9e
to
16a5db5
Compare
|
Thank you for your pull request. Before we can look at your contribution, we need to ensure all contributors are covered by a Contributor License Agreement. After the following items are addressed, please respond with a new comment here, and the automated system will re-verify.
Regards, |
|
I think I have set everything up now! |
Maydell
force-pushed
the
bufconn-deadlines
branch
2 times, most recently
from
ac4f525
to
8dcb2d4
Compare
Maydell
force-pushed
the
bufconn-deadlines
branch
from
8dcb2d4
to
eb5734f
Compare
Maydell
changed the title
Maydell
force-pushed
the
bufconn-deadlines
branch
5 times, most recently
from
cb5ffd5
to
2e7d845
Compare
Maydell
changed the title
|
Sorry for making such big changes after the initial review but I got a better idea to solve this PR. |
test/bufconn/bufconn_test.go
Outdated
| } | ||
|
|
||
| p1, p2 := newPipe(5), newPipe(5) | ||
| c1, c2 := &conn{p1, p2}, &conn{p1, p2} |
There was a problem hiding this comment.
As we write to c1 that would make c2 able to read from p2, and no longer be blocking. I changed it to c1, c2 := &conn{p1, p1}, &conn{p2, p2} to make this clearer.
Maydell
force-pushed
the
bufconn-deadlines
branch
from
2e7d845
to
aa4196a
Compare
dfawley
changed the title
|
Thank you! This was my first open source contribution so thank you for the guidance and feedback :) |
This PR adds implementations for the
Set(Read|Write)Deadlinefunctions of thenet.Conninterface. This functionality can be useful when testing I/O edge-cases or unreliable network connections.