Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix reflection doc #3138

Merged
merged 1 commit into from
Nov 4, 2019
Merged

docs: fix reflection doc #3138

merged 1 commit into from
Nov 4, 2019

Conversation

asoorm
Copy link
Contributor

@asoorm asoorm commented Nov 4, 2019

added git submodule update --init to readme instructions to pull in missing dependencies.

@asoorm
docs: fix missing dependencies
ed14453 
added `git submodule update --init` to readme instructions to pull in missing dependencies.
menghanl
menghanl approved these changes Nov 4, 2019
View reviewed changes
Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@menghanl menghanl added no release notes Type: Documentation Documentation or examples labels Nov 4, 2019
@menghanl menghanl changed the title docs: fix missing dependencies docs: fix reflection doc Nov 4, 2019
@menghanl menghanl merged commit 7c97d1d into grpc:master Nov 4, 2019
@lock lock bot locked as resolved and limited conversation to collaborators May 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees
No one assigned
Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@asoorm @menghanl