Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: replace manual.GenerateAndRegisterManualResolver with grpc.WithResolvers #3700

Merged
merged 1 commit into from
Jun 23, 2020
Merged

test: replace manual.GenerateAndRegisterManualResolver with grpc.WithResolvers #3700

merged 1 commit into from
Jun 23, 2020

Conversation

zouyee
Copy link
Contributor

@zouyee zouyee commented Jun 19, 2020

fix #3380

@zouyee zouyee marked this pull request as draft June 19, 2020 09:35
@zouyee
Copy link
Contributor Author

zouyee commented Jun 23, 2020

/retest

@zouyee zouyee marked this pull request as ready for review June 23, 2020 05:55
@zouyee
Copy link
Contributor Author

zouyee commented Jun 23, 2020

/assign @easwars

menghanl
menghanl approved these changes Jun 23, 2020
View reviewed changes
Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. LGTM!

@menghanl menghanl changed the title replace manual.GenerateAndRegisterManualResolver with grpc.WithResolvers test: replace manual.GenerateAndRegisterManualResolver with grpc.WithResolvers Jun 23, 2020
@menghanl menghanl merged commit 4e63bca into grpc:master Jun 23, 2020
@zouyee zouyee deleted the resolver branch June 24, 2020 01:53
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees
No one assigned
Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cleanup: replace manual.GenerateAndRegisterManualResolver with grpc.WithResolvers
2 participants
@zouyee @menghanl