meshca: Pull in the MeshCA config proto from grpc-proto repo. #3807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
easwars
added
no release notes
Type: Feature
easwars
force-pushed
the
meshca_config_proto
branch
from
6df6cb7
to
d20f84a
Compare
|
I have excluded the |
dfawley
reviewed
Aug 12, 2020
regenerate.sh
Outdated
| "https://github.com/envoyproxy/protoc-gen-validate" | ||
| ) | ||
| for repo in ${ENVOY_API_REPOS[@]}; do | ||
| dirname=`basename ${repo}` |
There was a problem hiding this comment.
Use $( instead of backticks please.
regenerate.sh
Outdated
Comment on lines
74
to
82
| MAPPINGS=( | ||
| "grpc/service_config/service_config.proto=/internal/proto/grpc_service_config" | ||
| "envoy/config/core/v3/config_source.proto=github.com/envoyproxy/go-control-plane/envoy/config/core/v3" | ||
| ) | ||
| OPTS="" | ||
| for i in "${MAPPINGS[@]}" | ||
| do | ||
| OPTS+="M$i," | ||
| done |
There was a problem hiding this comment.
I don't think this extra complexity is a good idea. Just write it literally:
OPTS=Mgrpc/service_config/service_config.proto=/internal/proto/grpc_service_config,\
Menvoy/config/core/v3/config_source.proto=github.com/envoyproxy/go-control-plane/envoy/config/core/v3
(Also, the code above leaves a trailing comma which apparently works now, but doesn't seem like a good thing to be doing.)
easwars
commented
Aug 12, 2020
regenerate.sh
Outdated
| "https://github.com/envoyproxy/protoc-gen-validate" | ||
| ) | ||
| for repo in ${ENVOY_API_REPOS[@]}; do | ||
| dirname=`basename ${repo}` |
regenerate.sh
Outdated
Comment on lines
74
to
82
| MAPPINGS=( | ||
| "grpc/service_config/service_config.proto=/internal/proto/grpc_service_config" | ||
| "envoy/config/core/v3/config_source.proto=github.com/envoyproxy/go-control-plane/envoy/config/core/v3" | ||
| ) | ||
| OPTS="" | ||
| for i in "${MAPPINGS[@]}" | ||
| do | ||
| OPTS+="M$i," | ||
| done |
dfawley
approved these changes
Aug 12, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.