advancedtls: Get Instant Updates Before Ticker Runs #3959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@easwars Could you please take a look? Thank you so much! |
easwars
requested changes
Oct 15, 2020
easwars
approved these changes
Oct 15, 2020
|
Thanks for the prompt review! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to fix a bug in advancedtls that the credential updates won't get updated immediately when the application starts. Under current implementation, once the user set the polling interval, it will wait that amount of time and then begin the first loading. It will cause problems if the client rpc context duration is shorter than the polling interval.
This PR is to fix this problem.