Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

some cleanup #401

Merged
merged 1 commit into from
Oct 15, 2015
Merged

some cleanup #401

merged 1 commit into from
Oct 15, 2015

Conversation

iamqizhao
Copy link
Contributor

  • msgFixedHeader
  • change length to unint32 in encode()
  • toRPCErr handles rpcError input

iamqizhao added a commit that referenced this pull request Oct 15, 2015
@iamqizhao
Merge pull request #401 from iamqizhao/master
a90aeac 
some cleanup
@iamqizhao iamqizhao merged commit a90aeac into grpc:master Oct 15, 2015
@iamqizhao
Copy link
Contributor Author

I am changing it to uint in #402. The original code cannot be compiled with Go 1.3 on my mac (int overflow error), which is not required but not pleasant.

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@iamqizhao @dsymonds