xds: report drops by circuit breaking #4171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Those drops will be reported to store with category "". When reported via LRS, they will only be counted in total_drops, but not in per category.
menghanl
force-pushed
the
circuit_breaking_drop_reporting
branch
2 times, most recently
from
0b5c5c0
to
f063116
Compare
menghanl
force-pushed
the
circuit_breaking_drop_reporting
branch
from
f063116
to
7baecdd
Compare
easwars
reviewed
Jan 25, 2021
|
|
||
| // ClearCounterForTesting clears the counter for the service. Should be only | ||
| // used in tests. | ||
| func ClearCounterForTesting(serviceName string) { |
There was a problem hiding this comment.
Should this return an error if serviceName is not found in the map?
There was a problem hiding this comment.
I think this doesn't matter.
Or are you suggesting that we should fail the test if this cleanup can't find the counter?
| // Drops by circuit breaking are reported with empty category. They | ||
| // will be reported only in total drops, but not in per category. | ||
| if d.loadStore != nil { | ||
| d.loadStore.CallDropped("") |
There was a problem hiding this comment.
Why do we report these with an empty category instead of using a category which makes it clear that these calls were dropped because of circuit-breaking?
There was a problem hiding this comment.
This is defined in the design doc.
And I believe the reason behind is that envoy doesn't report those with category.
dfawley
approved these changes
Jan 25, 2021
xds/internal/client/load/store.go
Outdated
| if keyStr != "" { | ||
| // Skip drops without category. They are counted in total_drops, but | ||
| // not in per category. One example is drops by circuit breaking. | ||
| sd.Drops[key.(string)] = d |
This was referenced Mar 8, 2021
This was referenced Mar 15, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those drops will be reported to store with category "". When reported via LRS,
they will only be counted in total_drops, but not in per category.
fixes #4138