Finish tracing when failing to create a client stream #491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is right. If NewStream fails, it could be for some reason that you'd want to see in a trace. For instance, one way NewStream can fail is if the context has already expired. If someone tried to start an RPC that way, we should show the trace as failing (and for that reason), not silently avoid tracing it. |
iamqizhao
changed the title
|
sgtm. Done. |
|
LGTM |
iamqizhao
added a commit
that referenced
this pull request
Jan 14, 2016
Finish tracing when failing to create a client stream
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.