Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rls: move pb.gos to grpc/internal/proto/grpc_lookup_v1 #4993

Merged
merged 1 commit into from
Nov 19, 2021
Merged

rls: move pb.gos to grpc/internal/proto/grpc_lookup_v1 #4993

merged 1 commit into from
Nov 19, 2021

Conversation

easwars
Copy link
Contributor

@easwars easwars commented Nov 19, 2021

We need the pb.gos to be outside of rls/internal to be used in e2e tests.

RELEASE NOTES: none

@easwars
rls: move pb.gos to grpc/internal/proto/grpc_lookup_v1
a01cbec 
We need the pb.gos to be outside of rls/internal to be used in e2e
tests.
@easwars easwars requested a review from dfawley November 19, 2021 00:22
@easwars easwars added the Type: Internal Cleanup Refactors, etc label Nov 19, 2021
@easwars easwars added this to the 1.43 release milestone Nov 19, 2021
@dfawley dfawley assigned easwars and unassigned dfawley Nov 19, 2021
@easwars easwars merged commit f45e617 into grpc:master Nov 19, 2021
@easwars easwars deleted the move_rls_protos branch November 19, 2021 00:51
@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 18, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dfawley dfawley dfawley approved these changes

Assignees

@easwars easwars

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.43 Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@easwars @dfawley