Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github: update to test with Go 1.18 #5262

Merged
merged 1 commit into from Mar 22, 2022
Merged

github: update to test with Go 1.18 #5262

merged 1 commit into from Mar 22, 2022

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented Mar 21, 2022

RELEASE NOTES: n/a

@dfawley dfawley added the Type: Meta Github repo, process, etc label Mar 21, 2022
@dfawley dfawley added this to the 1.46 Release milestone Mar 21, 2022
menghanl
menghanl approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@menghanl menghanl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the removed 1.17 tests are still "required" checks..

@dfawley
Copy link
Member Author

dfawley commented Mar 22, 2022

Some of the removed 1.17 tests are still "required" checks..

Now that this is approved I'll switch them to optional and the 1.18s to required.

@dfawley dfawley merged commit 9d08896 into grpc:master Mar 22, 2022
@dfawley dfawley deleted the go118 branch March 22, 2022 18:28
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@menghanl menghanl menghanl approved these changes

Assignees

@dfawley dfawley

Labels
Type: Meta Github repo, process, etc
Projects
None yet
Milestone
1.46 Release
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dfawley @menghanl