Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds: Fixed GoLang regression for Outlier Detection #5537

merged 1 commit into from Jul 25, 2022


Copy link

@zasweq zasweq commented Jul 25, 2022

This PR fixes a bug in Outlier Detection, when Outlier Detection was set to true the configuration would be prepared which would try and Build a placeholder balancer which would fail RPC's. This hardcodes the Environment Variable configuration to false, which will be changed when my full Outlier Detection PR gets merged. This will need to get backported to 1.48, as the bug is present in that branch too.


  • xds: Fix bug when environment variable GRPC_EXPERIMENTAL_ENABLE_OUTLIER_DETECTION is set to true

@zasweq zasweq added this to the 1.49 Release milestone Jul 25, 2022
@zasweq zasweq requested review from easwars and dfawley July 25, 2022 19:35
Copy link

Copy link

@sergiitk sergiitk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test passed. Thanks for the quick fix. Don't forget to backport to 1.48!

@zasweq zasweq merged commit ae261b0 into grpc:master Jul 25, 2022
29 checks passed
zasweq added a commit to zasweq/grpc-go that referenced this pull request Jul 26, 2022
xds: Fixed GoLang regression for Outlier Detection
zasweq added a commit that referenced this pull request Jul 26, 2022
xds: Fixed GoLang regression for Outlier Detection
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet

Successfully merging this pull request may close these issues.

None yet

4 participants