rls: suppress picker updates from children when handling config updates #5539
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zasweq
reviewed
Jul 28, 2022
balancer/rls/balancer_test.go
Outdated
| // update is being processed by RLS LB policy and its child policies. | ||
| // | ||
| // The test uses a wrapping balancer as the top-level LB policy on the channel. | ||
| // The wrapping balancing wraps an RLS LB policy as a child policy and forwards |
dfawley
approved these changes
Jul 29, 2022
| b.inhibitPickerUpdates = false | ||
| b.sendNewPickerLocked() | ||
| close(update.done) | ||
| b.stateMu.Unlock() | ||
| } |
There was a problem hiding this comment.
Defensive programming: default: logger.Errorf("%T", update)
balancer/rls/balancer.go
Outdated
| } | ||
|
|
||
| type connectivityStateCh struct{} |
There was a problem hiding this comment.
Can we find a better name? controlChannelReady?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes:
run()goroutine.UpdateClientConnState()UpdateState()run()goroutine.SendNewPickerLocked()UpdateClientConnState), a new picker is built but is not pushed up.What these change means is that when the RLS LB policy is handling a config update from its parent, no picker updates will be pushed up. This includes picker updates caused by events such as RLS response, cache timer expiry, backoff timer expiry etc.
Fixes #5211
RELEASE NOTES: n/a