Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xds: http header match with string matcher #6005

Closed
wants to merge 1 commit into from

xds: http header match with string matcher

379a309
Select commit
Loading
Failed to load commit list.
Closed

xds: http header match with string matcher #6005

xds: http header match with string matcher
379a309
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable failed Aug 7, 2023 in 3s

2/3 Fail(s): LABEL, MILESTONE

Status: FAIL

    Here are some stats of the run:
    3 validations were ran.
    1 PASSED
    2 FAILED

Details

❌ Validator: LABEL

  • ❌ label does not include "^Type:"
    Input :
    Settings : {"must_include":{"regex":"^Type:"}}

✔️ Validator: DESCRIPTION

  • ✔️ description must include '^RELEASE NOTES:\s([Nn][Oo][Nn][Ee]|[Nn]/[Aa]|\n(*|-)\s.+)$'**
    Input : Client requests type.googleapis.com/envoy.config.route.v3.RouteConfiguration from xds server, the result type of HeadMatcher maybe StringMatcher, the commit aims to support it.

RELEASE NOTES:

  • xds: http header match with string matcher
    Settings : {"must_include":{"regex":"^RELEASE NOTES:\\s*([Nn][Oo][Nn][Ee]|[Nn]/[Aa]|\\n(\\*|-)\\s*.+)$","regex_flag":"m"}}

❌ Validator: MILESTONE

  • ❌ milestone does not include "Release$"
    Input :
    Settings : {"must_include":{"regex":"Release$"}}
View more details on Mergeable