travis: build against go1.5.3, go1.6 #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
1.4.3 seems too far in the past. This repo depends on x/net (and maybe some other Go subrepository), and those only officially support Go 1.5 onwards. |
|
I agree, but the README says it "requires Go 1.4 or above", which implies Go 1.4 is supported. |
|
That probably needs fixing too, then. ;-) |
|
Happy to change both to say 1.5 (or even add a section on only supporting the last two stable versions of Go). Perhaps this is something we (Google) should standardize on for |
|
This seems reveal a data race in serverHandlerTransport. @bradfitz |
|
@iamqizhao, I see it. I filed a bug. Sorry about that. |
gopherbot
pushed a commit
to golang/net
that referenced
this pull request
Mar 25, 2016
Git rev e7da8ed (CL 20542) introduced an optimization to reuse the 64k request body buffers across multiple requests. But ServeHTTP handlers could retain them too long and cause races. Temporarily revert the main part of that CL until a proper fix is in. Updates golang/go#14960 Updates grpc/grpc-go#604 Change-Id: I28450e797a1d3122868214700b6ef345a0a1a47c Reviewed-on: https://go-review.googlesource.com/21160 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
|
Pls remove 1.4 then. I will update the README correspondingly. |
|
Updated. |
iamqizhao
changed the title
gopherbot
pushed a commit
to golang/net
that referenced
this pull request
Oct 19, 2016
name old time/op new time/op delta ServerPosts-4 192µs ± 1% 164µs ± 1% -14.16% (p=0.000 n=17+19) name old alloc/op new alloc/op delta ServerPosts-4 69.8kB ± 0% 2.8kB ± 0% -95.95% (p=0.000 n=18+18) name old allocs/op new allocs/op delta ServerPosts-4 42.0 ± 0% 40.0 ± 0% -4.76% (p=0.000 n=20+20) This is a redo of git rev e7da8ed (golang.org/cl/20542) which had a race and was later reverted in golang.org/cl/21160. Updates golang/go#14960 Updates grpc/grpc-go#604 Change-Id: Ie216e45730dce4fc0c58f295bcbc669973145599 Reviewed-on: https://go-review.googlesource.com/31447 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
c3mb0
pushed a commit
to c3mb0/net
that referenced
this pull request
Apr 2, 2018
Git rev e7da8ed (CL 20542) introduced an optimization to reuse the 64k request body buffers across multiple requests. But ServeHTTP handlers could retain them too long and cause races. Temporarily revert the main part of that CL until a proper fix is in. Updates golang/go#14960 Updates grpc/grpc-go#604 Change-Id: I28450e797a1d3122868214700b6ef345a0a1a47c Reviewed-on: https://go-review.googlesource.com/21160 Reviewed-by: Brad Fitzpatrick <bradfitz@golang.org>
c3mb0
pushed a commit
to c3mb0/net
that referenced
this pull request
Apr 2, 2018
name old time/op new time/op delta ServerPosts-4 192µs ± 1% 164µs ± 1% -14.16% (p=0.000 n=17+19) name old alloc/op new alloc/op delta ServerPosts-4 69.8kB ± 0% 2.8kB ± 0% -95.95% (p=0.000 n=18+18) name old allocs/op new allocs/op delta ServerPosts-4 42.0 ± 0% 40.0 ± 0% -4.76% (p=0.000 n=20+20) This is a redo of git rev e7da8ed (golang.org/cl/20542) which had a race and was later reverted in golang.org/cl/21160. Updates golang/go#14960 Updates grpc/grpc-go#604 Change-Id: Ie216e45730dce4fc0c58f295bcbc669973145599 Reviewed-on: https://go-review.googlesource.com/31447 Run-TryBot: Brad Fitzpatrick <bradfitz@golang.org> TryBot-Result: Gobot Gobot <gobot@golang.org> Reviewed-by: Ian Lance Taylor <iant@golang.org>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, grpc-go is only built against go 1.4.x.