Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orca: fix race when calling listeners coincides with updating the run goroutine #6258

Merged
merged 2 commits into from May 5, 2023

Conversation

dfawley
Copy link
Member

@dfawley dfawley commented May 5, 2023

Blocking on p.stopped while holding p.mu can race if the run goroutine had just received a report and is trying to acquire p.mu in order to call the listeners.

Waiting for the run goroutine to exit before starting a new one is not necessary. This change will start a new one without waiting, and only wait during producer shutdown (which is also not strictly necessary, but is a good idea to ensure all resources are cleaned up).

RELEASE NOTES: none

@dfawley dfawley merged commit f193ec0 into grpc:master May 5, 2023
11 checks passed
@dfawley dfawley deleted the orcarace branch May 5, 2023 21:25
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants