Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase 2 for server interceptor: The installation of server unary interceptor #645

Merged
merged 3 commits into from Apr 20, 2016

Conversation

iamqizhao
Copy link
Contributor

No description provided.

@bufdev
Copy link
Contributor

bufdev commented Apr 19, 2016

I assume the discussion on chaining interceptors is officially over? :)

@bufdev
Copy link
Contributor

bufdev commented Apr 19, 2016

It would be just as easy to allow multiple interceptors, and if there are >1 interceptors when you parse the options for the server, combine all the interceptors into one with a wrapper interceptors that calls all the given interceptors in order, this satisfies everyone

@iamqizhao
Copy link
Contributor Author

chaining is left to contrib/ or the applications themselves. :)

@menghanl menghanl merged commit 1a59283 into grpc:master Apr 20, 2016
@bufdev
Copy link
Contributor

bufdev commented Apr 20, 2016

Why can't we do it here if it's so super super easy? It will mean more fragmentation if we don't

@lock lock bot locked as resolved and limited conversation to collaborators Jan 20, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants