Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

balancer/weightedroundrobin: fix ticker leak on update #6655

Merged
merged 1 commit into from
Sep 21, 2023

balancer/weightedroundrobin: fix ticker leak on update (#6643)

e85a8f1
Select commit
Loading
Failed to load commit list.
Merged

balancer/weightedroundrobin: fix ticker leak on update #6655

balancer/weightedroundrobin: fix ticker leak on update (#6643)
e85a8f1
Select commit
Loading
Failed to load commit list.
Mergeable / Mergeable failed Mar 20, 2024 in 2s

1/3 Fail(s): MILESTONE

Status: FAIL

    Here are some stats of the run:
    3 validations were ran.
    2 PASSED
    1 FAILED

Details

✔️ Validator: LABEL

  • ✔️ label must include '^Type:'
    Input : Type: Bug
    Settings : {"must_include":{"regex":"^Type:"}}

✔️ Validator: DESCRIPTION

  • ✔️ description must include '^RELEASE NOTES:\s([Nn][Oo][Nn][Ee]|[Nn]/[Aa]|\n(*|-)\s.+)$'**
    Input : cherry-pick #6643

RELEASE NOTES:

  • balancer/weightedroundrobin: fix a memory leak caused by not stopping a time.Ticker
    Settings : {"must_include":{"regex":"^RELEASE NOTES:\\s*([Nn][Oo][Nn][Ee]|[Nn]/[Aa]|\\n(\\*|-)\\s*.+)$","regex_flag":"m"}}

❌ Validator: MILESTONE

  • milestone does not include "Release$"
    Input :
    Settings : {"must_include":{"regex":"Release$"}}