Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc: eliminate panics in server worker implementation #6856

Merged
merged 5 commits into from Dec 15, 2023
Merged

grpc: eliminate panics in server worker implementation #6856

merged 5 commits into from Dec 15, 2023

Commits on Dec 14, 2023

  1. grpc: eliminate panics in server worker implementation 

    This PR eliminates two possible panics:
- write to a closed channel
  - this was possible when the close of the serverWorkerChannel from
    Stop/GracefulStop was racing with handling of a new stream.
- close of a closed channel
  - this was possible when Stop/GracefulStop was called more than once.
    @easwars
    easwars committed Dec 14, 2023
    Copy the full SHA
    e9ea41d View commit details
    Browse the repository at this point in the history

  2. review comments; pass 1

    @easwars
    easwars committed Dec 14, 2023
    Copy the full SHA
    e1d3fab View commit details
    Browse the repository at this point in the history

  3. use context with defaultTestTimeout for RPCs

    @easwars
    easwars committed Dec 14, 2023
    Copy the full SHA
    fe69cb2 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2023

  1. make vet happy

    @easwars
    easwars committed Dec 15, 2023
    Copy the full SHA
    b31d719 View commit details
    Browse the repository at this point in the history

  2. remove wait for ready call option

    @easwars
    easwars committed Dec 15, 2023
    Copy the full SHA
    afc5e88 View commit details
    Browse the repository at this point in the history