Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xdsclient: use dataplane authority for virtualhost lookup #6997

Merged
merged 14 commits into from
Feb 28, 2024

nix comment

960d384
Select commit
Loading
Failed to load commit list.
Merged

xdsclient: use dataplane authority for virtualhost lookup #6997

nix comment
960d384
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Feb 23, 2024 in 0s

82.41% (-0.05%) compared to 76a23bf

View this Pull Request on Codecov

82.41% (-0.05%) compared to 76a23bf

Details

Codecov Report

Merging #6997 (960d384) into master (76a23bf) will decrease coverage by 0.05%.
The diff coverage is 66.66%.

❗ Current head 960d384 differs from pull request most recent head 7d919f7. Consider uploading reports for the commit 7d919f7 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6997      +/-   ##
==========================================
- Coverage   82.46%   82.41%   -0.05%     
==========================================
  Files         296      296              
  Lines       31465    31466       +1     
==========================================
- Hits        25947    25933      -14     
- Misses       4463     4476      +13     
- Partials     1055     1057       +2     
Files Coverage Δ
xds/internal/resolver/xds_resolver.go 78.99% <66.66%> (+0.06%) ⬆️

... and 19 files with indirect coverage changes