grpc: clean up doc strings and some code around Dial vs NewClient #7029
+130
−77
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #7029 +/- ##
==========================================
- Coverage 82.34% 82.33% -0.02%
==========================================
Files 296 296
Lines 31471 31475 +4
==========================================
Hits 25914 25914
- Misses 4491 4493 +2
- Partials 1066 1068 +2
|
arvindbr8
approved these changes
Mar 8, 2024
| @@ -632,7 +632,7 @@ func withHealthCheckFunc(f internal.HealthChecker) DialOption { | |||
| }) | |||
| } | |||
|
|
|||
| func defaultDialOptions(defScheme string) dialOptions { | |||
| func defaultDialOptions() dialOptions { | |||
There was a problem hiding this comment.
nit: There is only one usage of defaultDialOptions() which is in NewClient. How do you feel about putting this inline for more readability?
There was a problem hiding this comment.
I didn't make this, but I'd prefer to keep it like this. Having a separate function next to the struct like this makes it easy to find the default values. 🤷
This was referenced Apr 4, 2024
winkingturtle-vmw
added a commit
to cloudfoundry/locket
that referenced
this pull request
Apr 10, 2024
- [X] Read the [Contributing document](../blob/-/.github/CONTRIBUTING.md). Summary --------------- Context: Context: grpc/grpc-go#7029 Wait for status changed and return when connection is connected. Since DialContext has been removed, it's a bit unclear what needed to happen for connection to be ready for use. This code will bring back partial implementation of DialContext so that connection is ready. Backward Compatibility --------------- Breaking Change? **No**
1 task
geofffranks
pushed a commit
to cloudfoundry/locket
that referenced
this pull request
Apr 10, 2024
- [X] Read the [Contributing document](../blob/-/.github/CONTRIBUTING.md). Summary --------------- Context: Context: grpc/grpc-go#7029 Wait for status changed and return when connection is connected. Since DialContext has been removed, it's a bit unclear what needed to happen for connection to be ready for use. This code will bring back partial implementation of DialContext so that connection is ready. Backward Compatibility --------------- Breaking Change? **No**
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also added a test and removed an unused parameter from a function and call sites. (The reason it was needed in the past is to auto-detect the gRPCLB LB policy, which is functionality we no longer support.)
RELEASE NOTES: none