Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

golint fix: context.Context should be the first parameter of a function #7338

Merged
merged 1 commit into from
Jun 21, 2024
Merged

golint fix: context.Context should be the first parameter of a function #7338

merged 1 commit into from
Jun 21, 2024

Conversation

aranjans
Copy link
Contributor

Fixes golint error in xds/internal/balancer/ringhash/e2e/ringhash_balancer_test.go.

RELEASE NOTES: n/a

@aranjans aranjans added the Type: Internal Cleanup Refactors, etc label Jun 21, 2024
@aranjans aranjans added this to the 1.65 Release milestone Jun 21, 2024
@aranjans aranjans requested a review from purnesh42H June 21, 2024 08:59
@aranjans aranjans requested a review from easwars June 21, 2024 09:00
purnesh42H
purnesh42H approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@purnesh42H purnesh42H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks for picking this up!

@purnesh42H purnesh42H removed their assignment Jun 21, 2024
@easwars easwars merged commit a0311cd into grpc:master Jun 21, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easwars easwars easwars approved these changes

@purnesh42H purnesh42H purnesh42H approved these changes

Assignees

@easwars easwars

Labels
Type: Internal Cleanup Refactors, etc
Projects
None yet
Milestone
1.65 Release
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aranjans @easwars @purnesh42H