Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CFStream Test Suite Bazel Migration #48

Open
dennycd opened this issue Dec 16, 2021 · 1 comment
Open

CFStream Test Suite Bazel Migration #48

dennycd opened this issue Dec 16, 2021 · 1 comment
Assignees
Labels
area/bazel Bazel releated tool chain changes area/cfstream area/cocoapod Cocoapod Build Related kind/test Test coverage

Comments

@dennycd
Copy link
Contributor

dennycd commented Dec 16, 2021

Our CFStream test suite currently have a few issues that need to be improved

  • Test hangs and keep retries until timeout if test failure
  • Async test logic is using NSRunLoop mainRunLoop instead of XCTestExpectation

In addition, the current test suite is an objc translation from existing c-core test

We should revisit the test setup to run c-core's test setup using the corresponding ios unit test target instead


Additional todos for CFStream Test Update

  • Migrate CFStream test to bazel based
  • Move CFStream test out of test/core/iomgr and move into src/objective-c so that it is co-located with the rest of the ios/objc test.
@dennycd dennycd self-assigned this Dec 16, 2021
@HannahShiSFB HannahShiSFB self-assigned this Apr 4, 2022
@dennycd dennycd removed their assignment Apr 26, 2022
@dennycd dennycd added area/cocoapod Cocoapod Build Related area/bazel Bazel releated tool chain changes labels May 18, 2022
@dennycd dennycd assigned dennycd and unassigned HannahShiSFB Jun 17, 2022
@dennycd dennycd changed the title CFStream Test Suite Update CFStream Test Suite Bazel Migration Jun 17, 2022
@jtattermusch
Copy link
Collaborator

Note the the ios-test-cfstream-tests test suite is last one in the
grpc_basictests_objc_ios job.
After it gets migrated to bazel, we can basically get rid of the grpc_basictests_objc_ios job.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/bazel Bazel releated tool chain changes area/cfstream area/cocoapod Cocoapod Build Related kind/test Test coverage
Projects
None yet
Development

No branches or pull requests

3 participants