Skip to content

Commit

Permalink
util: Make grpc-core an implementation dependency
Browse files Browse the repository at this point in the history
This prevents grpc-core from being exposed on the classpath when
compiling code using grpc-util.
  • Loading branch information
ejona86 committed Nov 14, 2023
1 parent 6257c59 commit 0299788
Show file tree
Hide file tree
Showing 5 changed files with 8 additions and 3 deletions.
1 change: 1 addition & 0 deletions rls/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ tasks.named("jar").configure {

dependencies {
implementation project(':grpc-util'),
project(':grpc-core'),
project(':grpc-protobuf'),
project(':grpc-stub'),
libraries.auto.value.annotations,
Expand Down
3 changes: 2 additions & 1 deletion services/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@ dependencies {
api project(':grpc-protobuf'),
project(':grpc-stub'),
project(':grpc-util')
implementation libraries.protobuf.java.util,
implementation project(':grpc-core'),
libraries.protobuf.java.util,
libraries.guava.jre // JRE required by protobuf-java-util

runtimeOnly libraries.errorprone.annotations,
Expand Down
1 change: 1 addition & 0 deletions servlet/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ dependencies {
libraries.javax.annotation // java 9, 10 needs it

implementation project(':grpc-util'),
project(':grpc-core'),
libraries.guava

testImplementation 'javax.servlet:javax.servlet-api:4.0.1'
Expand Down
1 change: 1 addition & 0 deletions servlet/jakarta/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ dependencies {
libraries.javax.annotation

implementation project(':grpc-util'),
project(':grpc-core'),
libraries.guava

itImplementation project(':grpc-servlet-jakarta'),
Expand Down
5 changes: 3 additions & 2 deletions util/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,10 @@ tasks.named("jar").configure {
}

dependencies {
api project(':grpc-core')
api project(':grpc-api')

implementation libraries.animalsniffer.annotations,
implementation project(':grpc-core'),
libraries.animalsniffer.annotations,
libraries.guava
testImplementation libraries.guava.testlib,
testFixtures(project(':grpc-api')),
Expand Down

0 comments on commit 0299788

Please sign in to comment.