Skip to content

Commit

Permalink
Name old undertow servlet lib with version number
Browse files Browse the repository at this point in the history
This makes it clearer it isn't intended to be upgraded. We do this
already for the other servlet containers (e.g., jetty-servlet10).
  • Loading branch information
ejona86 committed Jul 12, 2024
1 parent 8ce4456 commit 2452730
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
4 changes: 2 additions & 2 deletions gradle/libs.versions.toml
Original file line number Diff line number Diff line change
Expand Up @@ -96,8 +96,8 @@ tomcat-embed-core9 = "org.apache.tomcat.embed:tomcat-embed-core:9.0.89"
# 1.4.3+ causes "unknown enum constant ElementType.MODULE" warning.
# https://github.com/google/truth/issues/1320
truth = "com.google.truth:truth:1.4.2"
undertow-servlet = "io.undertow:undertow-servlet:2.2.32.Final"
undertow-servlet-jakartaee9 = "io.undertow:undertow-servlet:2.3.14.Final"
undertow-servlet22 = "io.undertow:undertow-servlet:2.2.32.Final"
undertow-servlet = "io.undertow:undertow-servlet:2.3.14.Final"

# Do not update: Pinned to the last version supporting Java 8.
# See https://checkstyle.sourceforge.io/releasenotes.html#Release_10.1
Expand Down
2 changes: 1 addition & 1 deletion servlet/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@ dependencies {
exclude group: 'io.grpc', module: 'grpc-xds'
}

undertowTestImplementation libraries.undertow.servlet
undertowTestImplementation libraries.undertow.servlet22

tomcatTestImplementation libraries.tomcat.embed.core9

Expand Down
2 changes: 1 addition & 1 deletion servlet/jakarta/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ dependencies {
jettyTestImplementation libraries.jetty.servlet,
libraries.jetty.http2.server

undertowTestImplementation libraries.undertow.servlet.jakartaee9
undertowTestImplementation libraries.undertow.servlet
}

// Set up individual classpaths for each test, to avoid any mismatch,
Expand Down

0 comments on commit 2452730

Please sign in to comment.